[Libvirt-cim] [PATCH] [TEST] Update vsms.py and vxml.py to support emu_type for Xen and KVM, also pass for LXC
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Mon Jan 12 22:10:06 UTC 2009
I didn't see Deepti's review and also forgot to test on Xen. So I've
pushed this in.
Daisy - can you fix these items on the current tree? Thanks!
>>
> We will not have any value for disk assigned for Xen since none of the
> if conditional loops take care of this.
> We will get the following error the end of the function when we try to
> return d.mof in case Xen virt types.
>
> *UnboundLocalError: local variable 'd' referenced before assignment
>
> *You might want to do something like this to avoid passing emu_type for LXC:
> if virt == 'LXC':
> d = class_dasd(disk_dev, disk_source, dom_name)
> else:
> d = class_dasd(disk_dev, disk_source, dom_name, emu_type)
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list