[Libvirt-cim] [PATCH 1 of 2] [TEST] Modified the indication_tester.py to support MigrationIndications

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Jul 9 21:58:02 UTC 2009


>>
>> Anytime a change is made to other copy, the changes need to be pushed 
>> to the other so that the two remain in sync. These changes won't ever 
>> be used by the indication_tester.py itself, so I'm inclined to suggest 
>> moving them into their own module.
>>
>> Generally, I'm against having lots of different modules - I am in 
>> favor of consolidating where appropriate. However, I think this makes 
>> sense given that indication_tester is a special case.
>>
> I agree with you.. I too came up with the same problem of whether to 
> extend the indication_tester.py to include the new fns().
> I have moved the required fns() for Indications to a new file called 
> indications.py, so now indication_tester.py is independent to be moved 
> after the CSI/01_created_indication.py is modified to use the 
> indications.py fns().
> I think since we have a different dir which standalone tc, we can move 
> the indication_tester.py to suites/libvirt-cim/misc_cimtests/, and how 
> about migration_tester.py ...thoughts ??
> 

I think this is an excellent idea.  The tests will need to import 
CIMIndicationSubscription from indication_tester still, but it doesn't 
matter where the tester is located.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list