[Libvirt-cim] [PATCH 3 of 4] Added support for BusType prop on xmlgen and xml_parse_test

Richard Maciel rmaciel at linux.vnet.ibm.com
Thu Jun 11 01:31:38 UTC 2009


Again, bug description only targets block devices. I don't even know if 
file type disks works with this property.

Kaitlin Rupert wrote:
>>
>>  static void print_dev_vcpu(struct virt_device *dev,
>> diff -r efdd812a716e -r 54abd2088466 libxkutil/xmlgen.c
>> --- a/libxkutil/xmlgen.c    Sat Jun 06 22:46:51 2009 -0300
>> +++ b/libxkutil/xmlgen.c    Sat Jun 06 22:46:51 2009 -0300
>> @@ -60,6 +60,8 @@
>>          if (tmp == NULL)
>>                  return XML_ERROR;
>>          xmlNewProp(tmp, BAD_CAST "dev", BAD_CAST dev->virtual_dev);
>> +        if (dev->bus_type)
>> +                xmlNewProp(tmp, BAD_CAST "bus", BAD_CAST dev->bus_type);
>>
>>          if (dev->readonly)
>>                  xmlNewChild(disk, NULL, BAD_CAST "readonly", NULL);
> 
> What about for file type disks?  This only covers block type disks.


-- 
Richard Maciel, MSc
IBM Linux Technology Center
rmaciel at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list