[Libvirt-cim] [PATCH] Update template RASD in SettingsDefineCapabilities

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Jun 24 15:09:36 UTC 2009


> @@ -599,12 +608,14 @@
>          }
> 
>          
> -        s = set_net_props(template_type, ref, id, num_nics, "e1000", list);
> -        if (s.rc != CMPI_RC_OK)
> -                goto out;
> -     
> -        s = set_net_props(template_type, ref, id, num_nics, NULL, list);
> -
> +        for (i = 0; i < 2; i++) {
> +                for (j = 0; j < 2; j++) {
> +                        s = set_net_props(template_type, ref, id, type[i], NULL, num_nics, model[j], list);

For bridge type networks, you'll want to pass a sample value for 
net_name.  Also, this line is longer than 80 characters long.

Otherwise, looks good!


-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list