[Libvirt-cim] [PATCH] [TEST] #3 Add try / except to VSMS 15

[Deepti B Kalakeri]

Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1252002019 25200
> # Node ID 34e7c36ffd8acbb3d5ae5b60653e646f40a1793d
> # Parent  215cbc24f8f95f95543a24ecc7e3b1d80594ecdd
> [TEST] #3 Add try / except to VSMS 15
>
> Tested on Fedora 11 with KVM
>
> This will catch any unexpected exceptions.  Otherwise, the exception isn't
> caught and the guest may not be properly undefined
>
> Updates from 2 to 3:
>   -Replace cxml.start() with cxml.cim_start()
>   -Don't attempt to undefine the guest after calling cim_destroy(), since
>    DestroySystem() also does an undefine
>
> Updates from 1 to 2:
>   -Fix Exception() calls to use % instead of a , when specifying arguments
>   -Remove import of default_network_name
>   -Replace destroy() with cim_destroy()
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
>
>
> -    cleanup_env(options.ip, cxml)
> +    defined_domains = domain_list(options.ip, options.virt)
> +    if default_dom in defined_domains:
> +            cxml.cim_destroy(options.ip)
>
>   
There are more than 4 space here after the if condition.
+1 for me since this does not affect the test case execution.
Would be good if this is corrected next time.
> -    return PASS 
> +    curr_cim_rev, changeset = get_provider_version(options.virt, options.ip)
> +    if curr_cim_rev <= libvirt_f9_revision and options.virt == "KVM":
> +        return XFAIL_RC(f9_bug)
> +
> +    if options.virt == "LXC":
> +        return XFAIL_RC(bug)
> +
> +    return status 
>
>  if __name__ == "__main__":
>      sys.exit(main())
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>   

-- 
Thanks and Regards,
Deepti B. Kalakeri
IBM Linux Technology Center
deeptik at linux.vnet.ibm.com