[Libvirt-cim] [PATCH 2 of 5] [TEST] Added new tc to verify the RPCS error values with dir type pool

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Sep 16 03:37:49 UTC 2009


> +         
> +    except CIMError, (err_no, err_desc):
> +        if res[0] != PASS and exp_err_values[key]['msg'] in err_desc \
> +           and exp_err_no == err_no:
> +            logger.error("Got the expected error message: '%s' with '%s'", 
> +                          err_desc, key)
> +            return PASS

In the case where you're attempting to create a volume with a name that 
is already in use, this returns and the volume isn't cleaned up properly.

Sorry I missed this in previous reviews.

> +        else:
> +            logger.error("Failed to get the error message '%s'", 
> +                         exp_err_values[key]['msg'])
> +
> +    if res[0] == PASS:
> +        logger.error("Should not have been able to create Vol %s", vol_name)
> +        cleanup_vol(server, exp_vol_path)

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list