[Libvirt-cim] [PATCH] [TEST] #2 Verify that user can specify target dev for network interfaces

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Feb 2 20:31:14 UTC 2010


# HG changeset patch
# User Kaitlin Rupert <karupert at us.ibm.com>
# Date 1265142620 28800
# Node ID f74f985dfa2a4427ebbde3ab117b2b37463dd762
# Parent  3655b03ada11d9e99a1d10b97aaa7cdb737fc493
[TEST] #2 Verify that user can specify target dev for network interfaces

Updates:
  -Fix typo is error message
  -Start guest after defining it
  -Generate a random number to use in the NIC target device name. This will
   help ensure the device name is unique.

Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>

diff -r 3655b03ada11 -r f74f985dfa2a suites/libvirt-cim/cimtest/VirtualSystemManagementService/26_definesystem_nic_dev.py
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/26_definesystem_nic_dev.py	Tue Feb 02 12:30:20 2010 -0800
@@ -0,0 +1,147 @@
+#!/usr/bin/python
+#
+# Copyright 2010 IBM Corp.
+#
+# Authors:
+#    Kaitlin Rupert <karupert at us.ibm.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
+#    
+# Purpose:
+#   Verify provider's support for specifying the target device for vNICs 
+#
+# Steps:
+#  1) Build RASD parameters, making sure to specify target device for network
+#     interface 
+#  2) Create guest
+#  3) Verify guest is defined properly
+#
+
+import sys
+from random import randint
+from CimTest.Globals import logger
+from CimTest.ReturnCodes import FAIL, PASS, SKIP
+from XenKvmLib.classes import get_typed_class, inst_to_mof
+from XenKvmLib.rasd import get_default_rasds
+from XenKvmLib.const import do_main, get_provider_version
+from XenKvmLib.vxml import get_class
+from XenKvmLib.common_util import parse_instance_id
+from XenKvmLib.enumclass import EnumInstances
+from XenKvmLib.xm_virt_util import active_domain_list, domain_list
+
+sup_types = ['Xen', 'XenFV', 'KVM']
+test_dom = 'rstest_nic'
+
+target_dev_rev = 1028
+
+def get_rasd_list(ip, virt, target_dev):
+    nrasd_cn = get_typed_class(virt, "NetResourceAllocationSettingData")
+
+    rasds = get_default_rasds(ip, virt)
+
+    rasd_list = {} 
+
+    for rasd in rasds:
+        if rasd.classname == nrasd_cn and "Default" in rasd['InstanceID']:
+
+            rasd['VirtualDevice'] = target_dev
+
+        rasd_list[rasd.classname] = inst_to_mof(rasd)
+
+    return rasd_list 
+
+def verify_net_rasd(ip, virt, target_dev, guest_name):
+    inst = None
+
+    try:
+        nrasd_cn = get_typed_class(virt, 'NetResourceAllocationSettingData')
+        enum_list = EnumInstances(ip, nrasd_cn)
+
+        if enum_list < 1:
+            raise Exception("No %s instances returned" % nrasd_cn)
+
+        for rasd in enum_list:
+            guest, dev, status = parse_instance_id(rasd.InstanceID)
+            if status != PASS:
+                raise Exception("Unable to parse InstanceID: %s" % \
+                                rasd.InstanceID)
+
+            if guest == guest_name:
+                inst = rasd 
+                break
+
+        if inst is None:
+            raise Exception("%s instance for %s not found" % (nrasd_cn, 
+                            guest_name))
+
+        if inst.VirtualDevice != target_dev:
+            raise Exception("Expected VirtualDevice to be %s" % target_dev)
+
+    except Exception, details:
+        logger.error(details)
+        return FAIL
+
+    return PASS 
+
+ at do_main(sup_types)
+def main():
+    options = main.options
+
+    status = FAIL
+
+    curr_cim_rev, changeset = get_provider_version(options.virt, options.ip)
+    if curr_cim_rev < target_dev_rev:
+        logger.error("Network interface target device support is available" \
+                     " in rev >= %s", target_dev_rev)
+        return SKIP
+
+    cxml = get_class(options.virt)(test_dom)
+
+    tap_num = randint(1, 100)
+    target_dev = "vtap%s" % tap_num
+
+    try:
+        rasd_list = get_rasd_list(options.ip, options.virt, target_dev)
+        if len(rasd_list) < 1:
+            raise Exception("Unable to get template RASDs for %s" % test_dom)
+
+        cxml.set_res_settings(rasd_list)
+        ret = cxml.cim_define(options.ip)
+        if not ret:
+            raise Exception("Unable to define %s" % test_dom)
+
+        status = cxml.cim_start(options.ip)
+        if status != PASS:
+            raise Exception("Unable to start %s" % test_dom)
+
+        status = verify_net_rasd(options.ip, options.virt, target_dev, test_dom)
+        if status != PASS:
+            raise Exception("Failed to add net interface for %s" % test_dom)
+
+    except Exception, details:
+        logger.error(details)
+        status = FAIL
+
+    if test_dom in active_domain_list(options.ip, options.virt):
+        cxml.cim_destroy(options.ip)
+
+    if test_dom in domain_list(options.ip, options.virt):
+        cxml.undefine(options.ip)
+
+    return status 
+
+if __name__ == "__main__":
+    sys.exit(main())
+    




More information about the Libvirt-cim mailing list