[Libvirt-cim] [PATCH] libxkutil: Handle vnc password when retrieving domain XML

Eduardo Lima (Etrunko) eblima at linux.vnet.ibm.com
Mon Jul 18 15:01:17 UTC 2011


On 07/18/2011 11:41 AM, Chip Vincent wrote:
> +1 and pushed.
>
> BTW - Prior to this change, libvirt-cim was using the info store
> (has_vnc_passwd) for persisting the fact the password was set. It
> appears we can now remove that logic since the XML contains this data.
>
> For reference:
> Virt_VirtualSystemManagementService.c ~1548 sets has_vnc_passwd
> Virt_RASD.c ~457 fetches has_vnc_passwd
>
> Objections?
>

Code cleanups are always good. I had the impression that code was used 
by something else.

Best regards,

-- 
Eduardo de Barros Lima
Software Engineer, Open Virtualization
Linux Technology Center - IBM/Brazil
eblima at br.ibm.com




More information about the Libvirt-cim mailing list