[Libvirt-cim] [PATCH V3 01/11] remove script for bridge network

snmishra at linux.vnet.ibm.com snmishra at linux.vnet.ibm.com
Fri Dec 21 17:56:24 UTC 2012


+1

please test and make sure there are no regression.

-Sharad

Quoting Wenchao Xia <xiawenc at linux.vnet.ibm.com>:

> Yes, in lower version I think this xml section should also be removed.
>>
>> Are we saying that libvirt-cim 0.6.2 will use libvirt 0.9.10 and higher?
>>
>> Regards
>> Sharad Mishra
>> Open Virtualization
>> Linux Technology Center
>> IBM
>>
>>
>>
>> From:	Wenchao Xia <xiawenc at linux.vnet.ibm.com>
>> To:	veillard at redhat.com,
>> Cc:	Sharad Mishra/Beaverton/IBM at IBMUS, libvirt-cim at redhat.com,
>>              Wenchao Xia <xiawenc at linux.vnet.ibm.com>
>> Date:	12/18/12 02:20 AM
>> Subject:	[PATCH V3 01/11] remove script for bridge network
>>
>>
>>
>>    libvirt0.9.10 will report error if bridge network was defined
>> with script. This is the fix for it, otherwise VM start would fail.
>>
>> v2:
>>    rebased.
>>
>> Signed-off-by: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
>> ---
>>   libxkutil/xmlgen.c |    9 +--------
>>   1 files changed, 1 insertions(+), 8 deletions(-)
>>
>> diff --git a/libxkutil/xmlgen.c b/libxkutil/xmlgen.c
>> index 2dcd0d2..31619d8 100644
>> --- a/libxkutil/xmlgen.c
>> +++ b/libxkutil/xmlgen.c
>> @@ -269,18 +269,11 @@ static const char *set_net_source(xmlNodePtr nic,
>>           return NULL;
>>   }
>>
>> -
>> +/* libvirt 0.9.10 report error if script is set with brdige */
>>   static const char *bridge_net_to_xml(xmlNodePtr nic, struct net_device
>> *dev)
>>   {
>> -        const char *script = "vif-bridge";
>> -        xmlNodePtr tmp;
>>           const char *msg = NULL;
>>
>> -        tmp = xmlNewChild(nic, NULL, BAD_CAST "script", NULL);
>> -        if (tmp == NULL)
>> -                return XML_ERROR;
>> -        xmlNewProp(tmp, BAD_CAST "path", BAD_CAST script);
>> -
>>           msg = set_net_source(nic, dev, "bridge");
>>
>>           return msg;
>> --
>> 1.7.1
>>
>>
>
>
> --
> Best Regards
>
> Wenchao Xia
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim






More information about the Libvirt-cim mailing list