[Libvirt-cim] [PATCH 2/9] Change the MAC from "99:" to "88:"
WangXu
cngesaint at outlook.com
Wed Apr 24 06:25:04 UTC 2013
Reviewed-by: Xu Wang <cngesaint at outlook.com>
From: cngesaint at outlook.com
To: cngesaint at outlook.com
Subject: [Libvirt-cim] [PATCH 2/9] Change the MAC from "99:" to "88:"
Date: Wed, 24 Apr 2013 06:19:43 +0000
Using a MAC starting with "99:" is not legal. That ends up being a
Multicast Address since the low order bit of the first byte of the
address (in hex) is one. That is "99" is 0x10011001" in hex, where
the least significant bit is a "1" (one) indicating a multicast.
---
suites/libvirt-cim/cimtest/VSSD/06_duplicate_uuid.py | 2 +-
.../cimtest/VirtualSystemManagementService/06_addresource.py | 2 +-
.../cimtest/VirtualSystemManagementService/08_modifyresource.py | 4 ++--
.../VirtualSystemManagementService/13_refconfig_additional_devs.py | 4 ++--
.../cimtest/VirtualSystemManagementService/18_define_sys_bridge.py | 2 +-
.../VirtualSystemManagementService/22_addmulti_brg_interface.py | 2 +-
suites/libvirt-cim/lib/XenKvmLib/const.py | 6 +++---
suites/libvirt-cim/lib/XenKvmLib/test_xml.py | 2 +-
8 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/suites/libvirt-cim/cimtest/VSSD/06_duplicate_uuid.py b/suites/libvirt-cim/cimtest/VSSD/06_duplicate_uuid.py
index c5d8a22..be82335 100644
--- a/suites/libvirt-cim/cimtest/VSSD/06_duplicate_uuid.py
+++ b/suites/libvirt-cim/cimtest/VSSD/06_duplicate_uuid.py
@@ -40,7 +40,7 @@ from XenKvmLib.const import get_provider_version
sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
default_dom = 'uuid_domain'
test_dom = 'test_domain'
-nmac = '99:aa:bb:cc:ee:ff'
+nmac = '88:aa:bb:cc:ee:ff'
duplicate_uuid_support = 915
def get_vssd(ip, virt, dom):
diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/06_addresource.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/06_addresource.py
index fdcb84a..ac18c69 100644
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/06_addresource.py
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/06_addresource.py
@@ -38,7 +38,7 @@ from XenKvmLib.common_util import create_netpool_conf, destroy_netpool
sup_types = ['Xen', 'KVM', 'XenFV']
default_dom = 'rstest_domain'
-nmac = '99:aa:bb:cc:ee:ff'
+nmac = '88:aa:bb:cc:ee:ff'
ntype = 'network'
npool_name = default_network_name + str(random.randint(1, 100))
diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py
index df58d1f..a7c3871 100644
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py
@@ -43,9 +43,9 @@ cpu = 2
ncpu = 1
nmem = 131072
new_int = randint(10, 99)
-new_mac1 = "11:%s:22:%s:33:%s" % (new_int, new_int, new_int)
+new_mac1 = "88:%s:22:%s:33:%s" % (new_int, new_int, new_int)
new_int += 1
-new_mac2 = "11:%s:22:%s:33:%s" % (new_int, new_int, new_int)
+new_mac2 = "88:%s:22:%s:33:%s" % (new_int, new_int, new_int)
def cleanup_env(ip, cxml):
cxml.destroy(ip)
diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/13_refconfig_additional_devs.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/13_refconfig_additional_devs.py
index 6274527..a47db8f 100644
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/13_refconfig_additional_devs.py
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/13_refconfig_additional_devs.py
@@ -38,8 +38,8 @@ from XenKvmLib.vxml import get_class
sup_types = ['Xen', 'XenFV', 'KVM']
test_dom = 'rstest_domain'
test_dom2 = 'rstest_domain2'
-mac1 = '99:aa:bb:cc:ee:ff'
-mac2 = '99:aa:bb:cc:ee:aa'
+mac1 = '88:aa:bb:cc:ee:ff'
+mac2 = '88:aa:bb:cc:ee:aa'
REQUESTED_STATE = 2
TIME = "00000000000000.000000:000"
diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/18_define_sys_bridge.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/18_define_sys_bridge.py
index e02de29..66b3e45 100644
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/18_define_sys_bridge.py
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/18_define_sys_bridge.py
@@ -32,7 +32,7 @@ from XenKvmLib.common_util import create_netpool_conf, destroy_netpool
sup_types = ['Xen', 'KVM', 'XenFV']
default_dom = 'brgtest_domain'
-nmac = '99:aa:bb:cc:ee:ff'
+nmac = '88:aa:bb:cc:ee:ff'
npool_name = default_network_name + str(random.randint(1, 100))
brg_name = "br" + str(random.randint(1, 100))
diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/22_addmulti_brg_interface.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/22_addmulti_brg_interface.py
index 9abb21b..36d1873 100644
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/22_addmulti_brg_interface.py
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/22_addmulti_brg_interface.py
@@ -36,7 +36,7 @@ sup_types = ['Xen', 'KVM', 'XenFV']
test_dom = "my_domain1"
default_net = "my_network0"
test_net = "my_network1"
-test_mac = '99:aa:bb:cc:ee:ff'
+test_mac = '88:aa:bb:cc:ee:ff'
default_mac = "00:11:33:33:44:55"
ntype = 'bridge'
default_brg = 'mybr0'
diff --git a/suites/libvirt-cim/lib/XenKvmLib/const.py b/suites/libvirt-cim/lib/XenKvmLib/const.py
index 6dea644..6701d36 100755
--- a/suites/libvirt-cim/lib/XenKvmLib/const.py
+++ b/suites/libvirt-cim/lib/XenKvmLib/const.py
@@ -80,7 +80,7 @@ Xen_init_path = os.path.join(_image_dir, 'default-xen-initrd')
Xen_disk_path = os.path.join(_image_dir, 'default-xen-dimage')
Xen_secondary_disk_path = os.path.join(_image_dir, 'default-xen-dimage.2ND')
Xen_default_disk_dev = 'xvda'
-Xen_default_mac = '11:22:33:aa:bb:cc'
+Xen_default_mac = '88:22:33:aa:bb:cc'
# vxml.KVMXML
KVM_default_emulator = '/usr/bin/qemu-system-x86_64'
@@ -88,7 +88,7 @@ KVM_disk_path = os.path.join(_image_dir, 'default-kvm-dimage')
KVM_secondary_disk_path = os.path.join(_image_dir, 'default-kvm-dimage.2ND')
KVM_default_disk_dev = 'hda'
KVM_default_cdrom_dev = 'hdc'
-KVM_default_mac = '11:22:33:aa:bb:cc'
+KVM_default_mac = '88:22:33:aa:bb:cc'
# vxml.XenFVXML
s, o = platform.architecture()
@@ -109,7 +109,7 @@ LXC_default_emulator = '/usr/libexec/libvirt_lxc'
LXC_default_tty = '/dev/ptmx'
LXC_default_mp = '/tmp'
LXC_default_source = '/var/lib/libvirt/images/lxc_files'
-LXC_default_mac = '11:22:33:aa:bb:cc'
+LXC_default_mac = '88:22:33:aa:bb:cc'
LXC_netns_support = False
parser = OptionParser()
diff --git a/suites/libvirt-cim/lib/XenKvmLib/test_xml.py b/suites/libvirt-cim/lib/XenKvmLib/test_xml.py
index b32ae4c..914dbb0 100755
--- a/suites/libvirt-cim/lib/XenKvmLib/test_xml.py
+++ b/suites/libvirt-cim/lib/XenKvmLib/test_xml.py
@@ -42,7 +42,7 @@ kernel_path = os.path.join(image_dir, 'default-xen-kernel')
init_path = os.path.join(image_dir, 'default-xen-initrd')
disk_path = os.path.join(image_dir, 'default-xen-dimage')
-default_mac = '11:22:33:aa:bb:cc'
+default_mac = '88:22:33:aa:bb:cc'
def testxml(test_dom="domU1", mem = 128, vcpus = 1, mac = default_mac,
disk_file_path = disk_path, disk = "xvda"):
--
1.8.1.4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20130424/5a061845/attachment.htm>
More information about the Libvirt-cim
mailing list