[Libvirt-cim] [PATCH 2/3] Remove extranous or unnecessary parameter from error messages

John Ferlan jferlan at redhat.com
Thu Aug 8 22:16:41 UTC 2013


Testing on a system failed with:

Profile - 03_rprofile_gi_errs.py: FAIL
ERROR   - Unexpected errno 5, desc Class not found
ERROR   - Expected No such instance 6
ERROR   - NameError : global name 'tc' is not defined
Traceback (most recent call last):
  File "/root/cimtest/suites/libvirt-cim/lib/XenKvmLib/const.py", line 141, in do_try
    rc = f()
  File "03_rprofile_gi_errs.py", line 85, in main
    logger.error("------ FAILED: %s %s ------", cn, tc)
NameError: global name 'tc' is not defined
ERROR       - None

Turns out the profile test doesn't define/use tc. Found 2 other such
occurrances and fixed them as well.
---
 suites/libvirt-cim/cimtest/Profile/03_rprofile_gi_errs.py  | 2 +-
 suites/libvirt-cim/cimtest/RASD/03_rasd_errs.py            | 2 +-
 suites/libvirt-cim/cimtest/ResourcePool/02_rp_gi_errors.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/suites/libvirt-cim/cimtest/Profile/03_rprofile_gi_errs.py b/suites/libvirt-cim/cimtest/Profile/03_rprofile_gi_errs.py
index 4633cce..fa2a634 100644
--- a/suites/libvirt-cim/cimtest/Profile/03_rprofile_gi_errs.py
+++ b/suites/libvirt-cim/cimtest/Profile/03_rprofile_gi_errs.py
@@ -82,7 +82,7 @@ def main():
         logger.error("Expected %s %s", exp_desc, exp_rc)
 
     if status != PASS:
-        logger.error("------ FAILED: %s %s ------", cn, tc)
+        logger.error("------ FAILED: InstanceID Key Value. ------")
 
     Globals.CIM_NS = prev_namespace
     return status
diff --git a/suites/libvirt-cim/cimtest/RASD/03_rasd_errs.py b/suites/libvirt-cim/cimtest/RASD/03_rasd_errs.py
index 48cc34c..d582ffb 100644
--- a/suites/libvirt-cim/cimtest/RASD/03_rasd_errs.py
+++ b/suites/libvirt-cim/cimtest/RASD/03_rasd_errs.py
@@ -133,7 +133,7 @@ def main():
                 logger.error("Expected %s %s", exp_desc, exp_rc)
 
         if status != PASS:
-            logger.error("------ FAILED: %s %s ------", cn, tc)
+            logger.error("------ FAILED: %s ------", cn)
             break
 
     vsxml.undefine(server)
diff --git a/suites/libvirt-cim/cimtest/ResourcePool/02_rp_gi_errors.py b/suites/libvirt-cim/cimtest/ResourcePool/02_rp_gi_errors.py
index d06778e..6215684 100644
--- a/suites/libvirt-cim/cimtest/ResourcePool/02_rp_gi_errors.py
+++ b/suites/libvirt-cim/cimtest/ResourcePool/02_rp_gi_errors.py
@@ -94,7 +94,7 @@ def main():
                 logger.error("Expected %s %s", exp_desc, exp_rc)
 
         if status != PASS:
-            logger.error("------ FAILED: %s %s ------", cn, tc)
+            logger.error("------ FAILED: %s ------", cn)
             break
 
     return status 
-- 
1.8.3.1




More information about the Libvirt-cim mailing list