[Libvirt-cim] [PATCH 1/4] VSSD: Add properties for arch and machine

[Viktor Mihajlovski]

On 08/19/2013 10:35 AM, Wenchao Xia wrote:
> 于 2013-8-19 11:31, Wenchao Xia 写道:
>> 于 2013-8-15 22:48, Viktor Mihajlovski 写道:
>>> For architectures like s390 the machine type is relevant for
>>> the proper guest construction. We add the necessary properties
>>> to the schema and the C structures and the necessary code
>>> for CIM-to-libvirt mapping.
>>>
>>> While doing this I noticed that the union fields in os_info
>>> were set by means of XML parsing which doesn't take into account
>>> that certain fields are depending on the virtualization type.
>>    I think this is a issue. Could u split this patch into two:
>> 1 consider virt type for os_info, bugfix.
>> 2 add xml-domain-VSSD mapping for properties machine and arch.
>>
>>    Thus will make commit history clear and easier to review.
reasonable enough, I will send out a split version once
I get feedback for the other patches.
>>
[...]
>>    I haven't check DMTF docs, but wonder if there are existing DMTF file
>> point out where this property should belong. If no, I think put it
>> in VSSD is OK.
It wouldn't logically fit into a RASD since it defines an intrinsic
property of the guest, not of an associated resource, so VSSD is the
right place for the property.

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294