[Libvirt-cim] [PATCH V4] Fix kvm support check logic

[John Ferlan]

On 07/01/2013 11:54 AM, Viktor Mihajlovski wrote:
> On 07/01/2013 05:01 PM, John Ferlan wrote:
>>
>> I'm OK with the patch - I suppose the desire though is to have me push
>> it right :-)?
> well, I am not yet acquainted with the libvirt-cim who-is-who (or
> who-can-push) but I would appreciate this patch to go upstream.

It was more a question for the author since I've pushed the last couple
of patches I wasn't sure who would do this one.  In any case, I had to
make one small adjustment to the patch output, but I was able to 'git
am', run a test build, but I'm having some issues during testing.  I
think those are a self inflicted environment though.

The adjustment involved the difference line:

         virConnectPtr conn;

which did not have the prior update to add the "NULL" to the def:

         virConnectPtr conn = NULL;

because the following can go to out before conn was defined:

        if (disable_kvm) {
                CU_DEBUG("Enter disable kvm mode!");
                goto out;
        }


Before pushing I'd like to get verification from the author that the
cimtest works.


>>
>> Curious - are there other patches coming shortly or is this it for a
>> while?  Reason I'm asking deals with Red Hat releases - specifically the
>> need to have something for the 7.0 release.  I'm thinking the desire is
>> to perhaps generate a release with everything up to date.  That could
>> then be pushed into the RHEL 7.0.
>>
> Hm, it happens that I am currently looking at portability aspects
> of libvirt-cim. And although some patches could well result from this
> exercise I am not yet able to tell whether this would be in time for
> a specific distribution release level. Sorry for not being able to
> offer more at this point in time.
> 

Fair enough - it's probably a "this month" type timeframe.

John