[Libvirt-cim] [PATCH V3 04/11] CSI, add lock to protect shared data

[Wenchao Xia]

于 2013-3-11 22:41, John Ferlan 写道:
>
> Since I don't have the email to reply-to, here is a link:
>
> https://www.redhat.com/archives/libvirt-cim/2012-December/msg00026.html
>
>
> Why was the decision to reuse the lifecycle_mutex rather than generating
> a data specific mutex?  Seems like that mutex is used for other
> operations to protect filters and indications.  Thus unless the two are
> somehow tied, I really think it'd be better to create/use a data
> specific mutex.
>
> Furthermore, there's a few mutex adds around thread mgmt that probably
> should be a separate patch. That is - the non "dom_list" protection
> additions appear to be different.
>
> John
>
   It is just the quickest way to fix bug, it should be a separate lock
just as mentioned in the commit message for performance, you can form a
patch to fix it above or replace this patch.


> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>


-- 
Best Regards

Wenchao Xia