[Libvirt-cim] [PATCH 00/10] Adjustments based on recent review
Wenchao Xia
xiawenc at linux.vnet.ibm.com
Fri Mar 15 08:37:20 UTC 2013
Thanks for your patches, most seems good, some I can't confirm in
a short time. Since I am not the maintainer, I'll include those
got +1 in my serial with
Signed-off-by: John Ferlan <jferlan at redhat.com>
Reviewed-by: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
And then let Danial V decide whether to pull.
> As requested here is a series of patches to address a couple of issues
> I discovered during my initial foray into using libvirt-cim as well as
> from my code review. These are all *based on* the code I reviewed.
>
> Feel free to pick, choose, and apply. I have run them on my f18 system
> and things seem to work, but it's possible I've made a configuration error.
> I also will have a series of cimtest fixes, but I need to tidy them up
> a bit before sending.
>
> I did figure out that rather than uninstalling and reinstalling the
> package, I can use make preuninstall, make preinstall, restart the
> CIMOM, make install, and make postinsall which seems to replace the
> mofs "mostly correctly". There is an error in the postinstall phase
> which I haven't had the cycles to chase yet.
>
> John Ferlan (10):
> Remove empty newline at bottom
> Makefile.am: Remove the $(top_srcdir) from subst command
> xmlgen: Only support script on bridge for xen domains
> CSI: Fix bug found during 'make distcheck'
> Makefile.am: Use the top_srcdir rather than direct path in subst
> libxkutil: Use virConnectListAllDomains() to fetch domains
> libvirt-cim.spec: Use systemctl for tog-pegasus restart
> libxkutil: Adjust get_dominfo() logic
> DevicePool: Use the virConnectListAll interfaces
> register: Adjust the chatter output
>
> Makefile.am | 18 +++---
> libvirt-cim.spec.in | 10 ++-
> libxkutil/cs_util_instance.c | 23 +++++++
> libxkutil/device_parsing.c | 10 +--
> libxkutil/xmlgen.c | 25 +++++---
> provider-register.sh | 9 +--
> schema/SwitchService.registration | 1 -
> src/Virt_ComputerSystemIndication.c | 4 ++
> src/Virt_DevicePool.c | 121 +++++++++++++++++++++++++++++++++++-
> 9 files changed, 190 insertions(+), 31 deletions(-)
>
--
Best Regards
Wenchao Xia
More information about the Libvirt-cim
mailing list