[Libvirt-cim] [PATCH V5 12/15] CSI: Move native CSI code together
John Ferlan
jferlan at redhat.com
Thu Mar 21 18:33:16 UTC 2013
On 03/20/2013 11:39 PM, Wenchao Xia wrote:
> This is a pure code move patch. Now codes using libvirt event
> or native event, are moved into one macro protection, which make
> code easy to read, and in futher they can be moved into new file
> as CSI-libvirt.c.
> This patch also fix code style problem in moved code.
>
> Signed-off-by: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
> ---
> src/Virt_ComputerSystemIndication.c | 851 ++++++++++++++++++-----------------
> 1 files changed, 429 insertions(+), 422 deletions(-)
>
ACK - lots of trust here as it's not fun looking around for code
movement :-)
Personally, I prefer interlaced code as it's somewhat easier to maintain
long term. Now there's lots duplicated (eg, cut-n-paste) code that's
can be the source of future "issues" when one stream is changed but not
the other.
John
More information about the Libvirt-cim
mailing list