[Libvirt-cim] [PATCH 16/19] Coverity: Resolve UNINIT - vsss_delete_snapshot()

John Ferlan jferlan at redhat.com
Thu May 16 14:57:51 UTC 2013


(1) Event var_decl:
    Declaring variable "s" without initializer.

493             CMPIStatus s;
...

(6) Event uninit_use:
    Using uninitialized value "s": field "s"."msg" is uninitialized.

512             return s;

Resolve by initializing properly to CMPIStatus s = {CMPI_RC_OK, NULL};
---
 src/Virt_VirtualSystemSnapshotService.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Virt_VirtualSystemSnapshotService.c b/src/Virt_VirtualSystemSnapshotService.c
index 8c0889d..f4f3f86 100644
--- a/src/Virt_VirtualSystemSnapshotService.c
+++ b/src/Virt_VirtualSystemSnapshotService.c
@@ -490,7 +490,7 @@ static CMPIStatus create_snapshot(CMPIMethodMI *self,
 
 CMPIStatus vsss_delete_snapshot(const char *domname)
 {
-        CMPIStatus s;
+        CMPIStatus s = {CMPI_RC_OK, NULL};
         char *path = NULL;
 
         path = vsss_get_save_path(domname);
-- 
1.8.1.4




More information about the Libvirt-cim mailing list