[Libvirt-cim] Fwd: [PATCH V2 00/48] Solution to solve unsupported tag missing issue

Tue Nov 12 03:04:38 UTC 2013

Dear all,
There are more and more bugs were reported as unsupported tags missing
during resource
update. And this issue is becoming more and more serious. My mission is
solving this category
bugs from designing by the end of this year. So could you help me review
these patches and
give me your suggestion? I hope I can get more feedback from community
and solve it as soon
as possible. If there is anything I can explain please reply me. Thank
you very much.

Sincerely yours,
Xu Wang

-------- 原始消息 --------
主题: 	[PATCH V2 00/48] Solution to solve unsupported tag missing issue
日期: 	Mon, 28 Oct 2013 10:45:29 +0800
发件人: 	Xu Wang <cngesaint at gmail.com>
收件人: 	libvirt-cim at redhat.com
抄送: 	jferlan at redhat.com, mihajlov at linux.vnet.ibm.com, Xu Wang
<gesaint at linux.vnet.ibm.com>

What's new in V2:
  1. Rebase commit to the current upstream.
  2. Update console device support.
  3. Add id and parent_id to handle there are more than two sub-node but
     with the same issue.
  4. Add status (ACTIVE/INACTIVE) to identify if a node was fetched.
  5. Adjust the original designing plan. Now after fetched a node from link
     list just change its status from ACTIVE to INACTIVE instead of delete
     it. Purpose of this update is to make link list keep the structure of
     xml and regenerate xml easily.
  6. Necessary comments added.
  7. Add function (compare_param_int/compare_param_str) to adjust the result
     of comparation (if any parameter is NULL/-1 the comparation result is
     TRUE instead of FALSE.
  8. Bugs fixing. Such as attribute 'arch' under <type> of <os>, <dev> of
     <target> parsing, etc.

--------------------------------------------------------------------------
These patches are based on commit 04bfeb825e5e155ffa72119253de608ccf3bd72b.
So I may need more work on rebasing.

Most of bugs reported recently are about some tags libvirt-cim doesn't
support will be dropped after resource updated. So a new member was added
into every virt_device and domain structure. And a new structure named
unknown device was added to save those tags new added.

The original implementaion is reading every member of virt_device structure
from xml and save it. But the defect of this is some tags were not a
member of virt_device were dropped. After resource updated, every data
in the virt_device will be used to regenerate new xml. Hence the tags
unsupported above, disappeared.

So I added a member into every virt_device and domain structure, 'others'.
It's a link list and used to save all data read from xml. Another new
structure 'unknown_device' was added to save data except libvirt-cim could
recognize.

The new implementation is, firstly parse_*_device() could read all nodes and
properties from xml and save them into 'others' link list. Then every member
of virt_device will fetch data from others link list and save it. So that
nodes in the 'others' link list could be saved until they are used to re-
generate xml.

After resource updating finished, libvirt-cim will call *_xml() to generate
xml. The new process of generating xml like this, firstly all data in the
members of virt_device will be restored into 'others' link list, then a
function (others_to_xml) will use this link list to generate xml.

Some points I have updated,
  1. 'others' link list has to be processed in _get_proc_device() and
     _get_mem_device(). They should be copied into new data structure.
  2. If resource updating happened, others field should be cleared
     because this device has been changed and they are useless.

Besides above some logic may be a little strange or boring. Implemention
like that is just to be compatible with upper layer functions (to make
changes as less as possible). After keep a balance I decided to devide
the whole xml into several parts:
 <domain>------------------------others in domain to save unsupported sub-nodes of domain
                                -some fields (devices, mem, vcpu...) will be skiped because
                                -they have their own parsing functions.
  <name>xxx</name>
  <uuid>xxx</uuid>
  <vcpu>xxx</vcpu>
  <mem>xxx</mem>
  <devices>
    <disk>xxx</disk>------- others in virt_device to save unsupported tags of this device
    <emulator>xxx</emulator>
    ...----------- unknown_device to save unsupported device except like <disk>,<emu>,etc.
  </devices>
</domain>

Hence, all nodes read from xml will be restored after xml generation.

Xu Wang (48):
  Add others member for saving unsupported tag and unknown device
  Add others and unknown_device clean up
  Add basic operations for reading data from xml node
  Fix xml parsing algorithm for parse_fs_device()
  Fix xml parsing algorithm for parse_block_device()
  Fix xml parsing algorithm for parse_vsi_device()
  Fix xml parsing algorithm for parse_net_device()
  Fix xml parsing algorithm for parse_vcpu_device()
  Fix xml parsing algorithm for parse_emu_device()
  Fix xml parsing algorithm for parse_mem_device()
  Fix xml parsing algorithm for parse_console_device()
  Fix xml parsing algorithm for parse_graphics_device()
  Fix xml parsing algorithm for parse_input_device()
  Add parse_unknown_device()
  Add parse_devices() for unknown type in get_dominfo_from_xml()
  Fix xml parsing algorithm in parse_domain()
  Fix xml parsing algorithm in parse_os()
  Fix xml parsing algorithm in parse_feature()
  Add dup function for device copy
  Add type CIM_RES_TYPE_DELETED and modify type as it after
    resource_del
  Add basic functions about converting others link list to xml
  Fix xml generation algorithm in console_xml()
  Fix xml generation algorithm in disk_block_xml()
  Fix xml generation algorithm in disk_file_xml()
  Fix xml generation algorithm in disk_fs_xml()
  Fix xml generation algorithm in set_net_vsi()
  Fix xml generation algorithm in set_net_source()
  Fix xml generation algorithm in bridge_net_to_xml()
  Fix xml generation algorithm in net_xml()
  Fix xml generation algorithm in vcpu_xml()
  Fix xml generation algorithm in cputune_xml()
  Fix xml generation algorithm in mem_xml()
  Fix xml generation algorithm in emu_xml()
  Fix xml generation algorithm in graphics_vnc_xml()
  Fix xml generation algorithm in input_xml()
  Fix xml generation algorithm in system_xml()
  Fix xml generation algorithm in _xenpv_os_xml()
  Fix xml generation algorithm in _fv_bootlist_xml()
  Fix xml generation algorithm in _xenfv_os_xml()
  Fix xml generation algorithm in _kvm_os_xml()
  Fix xml generation algorithm in _lxc_os_xml()
  Fix xml generation algorithm in os_xml()
  Fix xml generation algorithm in features_xml()
  Add functions for xml generation of unknown devices
  Fix xml generation algorithm in system_to_xml()
  Add cleanup_others() calling during rasd_to_vdev()
  Add others handling in _get_mem_device()
  Add dup_others() into _get_proc_device()

 libxkutil/device_parsing.c                | 1959 ++++++++++++++++++++++-----
 libxkutil/device_parsing.h                |   64 +
 libxkutil/xmlgen.c                        | 2103 +++++++++++++++++++++++------
 src/Virt_VirtualSystemManagementService.c |   20 +-
 src/svpc_types.h                          |    1 +
 5 files changed, 3445 insertions(+), 702 deletions(-)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20131112/a66ea78e/attachment.htm>