[Libvirt-cim] [PATCH 2/5] libxkutil: Support for device addresses

[Viktor Mihajlovski]

On 11/19/2013 10:02 PM, John Ferlan wrote:
> On 10/14/2013 11:29 AM, Viktor Mihajlovski wrote:
>> New data type for device addresses based on the generic
>> "address" element of the libvirt domain XML.
>> Contains XML parsing and generation code for device addresses.
>>
>> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
>> ---
>>  libxkutil/device_parsing.c |  113 ++++++++++++++++++++++++++++++++++++++++++++
>>  libxkutil/device_parsing.h |   11 +++++
>>  libxkutil/xmlgen.c         |   28 +++++++++++
>>  3 files changed, 152 insertions(+)
>>
> 
> Although this is already pushed, while I was working through Xu's patch
> set I think I found a missed case.
> 
> The parsing code handles "parse_fs_device", "parse_block_device", and
> "parse_net_device"; however, the generation code does "disk_block_xml",
> "disk_file_xml", and "net_xml" missing out on "disk_fs_xml".
true ... will send a patch fixing it.

> 
> The "parse_block_device" handles both "source=file" and "source=dev",
> while "disk_xml" checks for DISK_PHY or DISK_FILE before parceling out
> to the corresponding subroutine.
> 
> John
> 

-- 

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294