[PATCH] audit_panic() renamed to audit_handle_failure()

Dustin Kirkland dustin.kirkland at us.ibm.com
Wed Aug 31 18:25:45 UTC 2005


It has become apparent that the name of the function currently labeled
"audit_panic" might mislead some developers.

This is due to the operation of the function, which may or may not
necessarily panic the kernel.  A look at the function shows that there
are currently three different paths the function can take, only one of
which will cause a kernel panic:

        static void audit_panic(const char *message)
        {
                switch (audit_failure)
                {
                case AUDIT_FAIL_SILENT:
                        break;
                case AUDIT_FAIL_PRINTK:
                        printk(KERN_ERR "audit: %s\n", message);
                        break;
                case AUDIT_FAIL_PANIC:
                        panic("audit: %s\n", message);
                        break;
                }
        }


The following simple patch renames the function "audit_panic" to
"audit_handle_failure" and updates all references to the function.


:-Dustin



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.6.13-rc6-mm2-audit_handle_failure.patch
Type: text/x-patch
Size: 3136 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-audit/attachments/20050831/4d772c1d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/linux-audit/attachments/20050831/4d772c1d/attachment.sig>


More information about the Linux-audit mailing list