[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [redhat-lspp] Re: [Patch] SE Linux audit events



On Wed, 2005-12-07 at 06:34 -0500, Steve Grubb wrote:
> On Tuesday 06 December 2005 14:59, Timothy R. Chavez wrote:
> > I believe it's common practice to place linux before asm, so:
> 
> details, details,...   :)
> 
> Attached is a patch that hardwires important SE Linux events to the audit 
> system. Please Apply.
> 
> Signed-off-by: Steve Grubb <sgrubb redhat com>

The code itself looks fine to me, but the patch is whitespace damaged
(you often have to take special steps when inlining a patch if using a
"user-friendly" mail client, as it will helpfully reformat it for you b
default; look for a Preformat or similar setting).

Make sure you run the patch through patch-tester.pl as well to check for
any actual problems in the original patch, see:
http://www.ussg.iu.edu/hypermail/linux/kernel/0505.1/1566/patch-tester.pl

-- 
Stephen Smalley
National Security Agency


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]