[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [RFC][PATCH] (#2) Prelim in-kernel file system auditing support



Right, so I guess the correct check will involve perhaps checking
nd.last!=NULL before d_lookup, or dentry != nd.dentry after the
d_lookup?

(I don't know offhand what nd.last looks like if you looked up '/'.)

-serge

On Tue, 2005-01-25 at 11:20 -0800, Chris Wright wrote:
> * Serge Hallyn (serue us ibm com) wrote:
> > But you're looking up the parent of the file.  So if you call
> > audit_insert_watch("/.autofsck"); then nd will be the nameidata for '/'.
> > You're going to check that the parent is not '/', whereas before you
> > were checking that the file is not '/'.  Clearly you want the latter.
> > 
> > That's not to say the strcmp(path, "/') will be acceptable upstream,
> > though.
> 
> No, it's not.  It also doesn't mean much.  Think "///", or "../../../".
> These are user strings.  If it's an issue, better compare against
> something sane like resolved internal data structure.
> 
> thanks,
> -chris
-- 
Serge Hallyn <serue us ibm com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]