[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [RFC][PATCH] (#2) Prelim in-kernel file system auditing support



Hi Tim,

One more thing.  Pay attention to your usage of
list_for_each_entry_safe.  I believe you want to use it every time you
iterate over an audit_file->watchlist.  You use list_for_each_entry for
one of those in audit_fetch_watch, but then use _safe while walking over
context->watched during audit_free_files, when I don't think you need
to.

-- 
Serge Hallyn <serue us ibm com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]