[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: repost of loginuid patches



On Thu, 2005-01-27 at 08:43 -0500, Stephen Smalley wrote:
> reading until he hits the end of the "file".  I think this code should
> be simplified along the lines of sel_read_enforce.  Did you mean to use
> scnprintf?
> 
> You'll want consistency, either auid or loginuid, not a mix.  loginuid
> is more consistent with the existing code.
> 
> Minor nit: In the AUDIT_USER messages, I'd put the loginuid right after
> the uid, not after the length (which is logically coupled with the msg).
> 
> Otherwise, I'd encourage you to take these to lkml.

Thanks, will do after I apply these three suggestions.

-serge
-- 
Serge Hallyn <serue us ibm com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]