[PATCH] LSPP audit enablement: storing selinux ocontext and scontext

[David Woodhouse]

On Thu, 2005-07-21 at 10:48 -0500, Dustin Kirkland wrote:
> I expect at least one section of this code to generate some animated
> discussion.  This code utilizes "static inline" function definitions
> rather than "#define" macros, as per Documentation/SubmittingPatches
> lines 328-372 and Documentation/CodingStyle line 358.  This is
> inconsistent with the rest of the code in include/linux/audit.h, so I
> suspect someone will have to give, in the interest of consistency.
> Please advise.

In this case the one-line #define is probably nicer. Let's stick with
that.

Please use kstrdup() in audit_set_macxattr().

Other than that it looks sane at first glance. Steve had some comments
to make, I think, but he's at OLS without a laptop so that may be
delayed...

-- 
dwmw2