[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: audit 0.9.12 released



On Thu, 2005-06-23 at 17:25 -0400, Steve Grubb wrote:
> > I'm more interested in finding the real reason why it didn't work. Were
> > you setting the syscall bitmask to all ones in auditctl?
> 
> Yes.

You pointed out the problem on IRC -- well spotted. Once I'd added the
task refcounting to audit_filter_user() it became more of a problem that
the function was violating the "only one return from each function"
rule. I fixed it to use a variable for the return code and always reach
the end, but in a fit of stupidity I left the 'return 1' at the end :)

audit.68 building now...

Index: kernel/auditsc.c
===================================================================
--- b75da428ad7067959b24a0e2e6b64094750025b9/kernel/auditsc.c  (mode:100644)
+++ uncommitted/kernel/auditsc.c  (mode:100644)
@@ -557,7 +557,7 @@
 	rcu_read_unlock();
 	put_task_struct(tsk);
 
-	return 1; /* Audit by default */
+	return ret; /* Audit by default */
 
 }
 


-- 
dwmw2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]