Possible performance bug

Chris Wright chrisw at osdl.org
Fri Sep 9 21:10:06 UTC 2005


* Steve Grubb (sgrubb at redhat.com) wrote:
> 227         movl TI_flags(%ebp), %ecx
> 228         testw $_TIF_ALLWORK_MASK, %cx
> 229         jne syscall_exit_work
> 
> So, Amy is right, the TIF_AUDIT flag has some bearing on the benchmarks.

How's this one go?

 kernel/auditsc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)

Index: linus-2.6/kernel/auditsc.c
===================================================================
--- linus-2.6.orig/kernel/auditsc.c
+++ linus-2.6/kernel/auditsc.c
@@ -606,8 +606,10 @@ int audit_alloc(struct task_struct *tsk)
 	struct audit_context *context;
 	enum audit_state     state;
 
-	if (likely(!audit_enabled))
+	if (likely(!audit_enabled)) {
+		clear_tsk_thread_flag(tsk, TIF_SYSCALL_AUDIT);
 		return 0; /* Return if not auditing. */
+	}
 
 	state = audit_filter_task(tsk);
 	if (likely(state == AUDIT_DISABLED))




More information about the Linux-audit mailing list