[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: moving audit_free() up into do_exit()



Alexander Viro <aviro redhat com> wrote:
>
> On Thu, Mar 30, 2006 at 03:54:53AM -0500, Alexander Viro wrote:
> > OK, preliminary patches attached; the first one is minimal "take care of
> 
> 

> +static void audit_log_task_info(struct audit_buffer *ab, struct task_struct *tsk, gfp_t gfp_mask)
>  {
>  -	char name[sizeof(current->comm)];
>  -	struct mm_struct *mm = current->mm;
>  +	char name[sizeof(tsk->comm)];
>  +	struct mm_struct *mm = tsk->mm;
>   	struct vm_area_struct *vma;
>   
>  -	get_task_comm(name, current);
>  +	get_task_comm(name, tsk);
>   	audit_log_format(ab, " comm=");
>   	audit_log_untrustedstring(ab, name);
> 

Am too lazy to apply the thing and check, but does `tsk' always equal
`current' here?   If not, what pins the mm_struct?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]