[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: audit-ptrace patch (untested)



On Wed, 7 Mar 2007, Stephen Smalley wrote:

> >  		audit_free_aux(context);
> >  		kfree(context->filterkey);
> > +		kfree(context->obj_ctx);
> 
> Technically, this should be:
> 	 security_release_secctx(context->obj_ctx, context->ctxlen);
> Although that does require keeping the length around, and the rest of
> the audit code is already assuming it is just a string (unlike the
> original user of these LSM hooks, the labeled IPSEC code).

I think these needs to be fixed before merge, as the presence of existing 
mistakes doesn't justify adding new ones.


- James
-- 
James Morris
<jmorris namei org>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]