[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Audit: close race between audit_syscall_exit and proc_loginuid_read



On Wed, 2007-10-03 at 14:29 -0400, Steve Grubb wrote:
> On Wednesday 03 October 2007 14:21:35 Eric Paris wrote:
> > audit_syscall_exit() calls audit_get_context() which returns the
> > tsk->audit_context but then also sets tsk->audit_context=NULL.
> 
> The preferred way to solve this problem is to promote loginuid to be part of 
> the task structure. We also have another problem where if the audit system is 
> temporarily disabled, loginuid will not be set in any new programs. What we'd 
> like to have happen is loginuid be available and usable all the time so that 
> we always know the auid when the audit system starts back up.

While obviously possible I don't see a reason that this patch is bad,
wrong, or shouldn't go in.  If things other than audit want to make use
of the loginuid I wouldn't see a problem putting it in the task struct
but as it stands now this patch fixes an obvious race for a solely audit
problem.

-Eric


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]