[PATCH] Add SELinux context and TTY name to AUDIT_TTY records

Miloslav Trmac mitr at redhat.com
Fri Mar 20 08:53:27 UTC 2009


Paul,
Thanks for your review.
----- "Paul Moore" <paul.moore at hp.com> wrote:
> There are several audit experts which should review this code but two
> things 
> jumped out at me when glancing at your patch:
> 
>  1. SELinux SIDs should not be recorded
Almost all code that logs SELinux contexts in kernel/audit* does the same thing as this patch, falling back to a SID if it can't be converted to a string.

>  2. From a SELinux/security point of view ttys are considered objects
>     and their labels/contexts should be recorded with "obj=" not
> "subj="
The patch logs the context of the process, not of the TTY.
    Mirek




More information about the Linux-audit mailing list