Missing linker flags when statically linking

[Steve Grubb]

On Saturday, July 9, 2016 11:02:44 PM EDT Laurent Bigonville wrote:
> Le 05/07/16 à 14:15, Steve Grubb a écrit :
> > Hello,
> > 
> > On Monday, July 4, 2016 2:08:14 PM EDT Laurent Bigonville wrote:
> >> Apparently the audit.pc file is missing flags to allow libaudit to be
> >> statically linked (see [0]).
> >> 
> >> Adding something like "Requires.private: libcap-ng" should fix the
> >> problem.
> > 
> > OK. Fixed. There will be a new audit package release in a little while
> > that
> > has this fixed.
> 
> Apparently the fix is not 100% correct:
> 
> The "Libs.private" field should be _after_ the Libs one in the .pc file,
> otherwise the ordering of the libraries is not OK during liking:
> 
> -lcap-ng -laudit
> 
> it should be: -laudit -lcap-ng instead.

OK, I switched the order.


> Also any reasons you are using Libs.private instead of Package.private?

Libs.private is used to add flags for static linking. The dynamic linker 
shouldn't need a hint since libaudit its already linked to libcap-ng.

Also, anyone packaging up audit 2.6.4 will want to include this patch:
https://fedorahosted.org/audit/changeset/1340

-Steve