[PATCH] audit: less stack usage for /proc/*/loginuid

Richard Guy Briggs rgb at redhat.com
Wed Nov 2 06:10:46 UTC 2016


On 2016-10-29 19:04, Alexey Dobriyan wrote:
> %u requires 10 characters at most not 20.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>

Ack, looks reasonable to me.  This has been there from the original
commit 1e2d1492e178 Serge Hallyn, Feb 2005.

> ---
> 
>  fs/proc/base.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -1243,7 +1243,7 @@ static const struct file_operations proc_oom_score_adj_operations = {
>  };
>  
>  #ifdef CONFIG_AUDITSYSCALL
> -#define TMPBUFLEN 21
> +#define TMPBUFLEN 11
>  static ssize_t proc_loginuid_read(struct file * file, char __user * buf,
>  				  size_t count, loff_t *ppos)
>  {

- RGB

--
Richard Guy Briggs <rgb at redhat.com>
Kernel Security Engineering, Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635




More information about the Linux-audit mailing list