[PATCH ghak73 V3] audit: re-structure audit field valid checks

[Paul Moore]

On Wed, May 22, 2019 at 5:51 PM Richard Guy Briggs <rgb at redhat.com> wrote:
>
> Multiple checks were being done in one switch case statement that
> started to cause some redundancies and awkward exceptions.  Separate the
> valid field and op check from the select valid values checks.
>
> Enforce the elimination of meaningless bitwise and greater/lessthan
> checks on string fields and other fields with unrelated scalar values.
>
> Please see the github issue
> https://github.com/linux-audit/audit-kernel/issues/73
>
> Signed-off-by: Richard Guy Briggs <rgb at redhat.com>
> ---
> Changelog:
> v3:
> - remove op negation for WATCH, DIR, PERM, FILETYPE (ghak114)
> - move AUDIT_{SUBJ_{CLR,SEN},OBJ_LEV_{LOW,HIGH}} to range
> v2:
> - address WATCH, DIR, FILETYPE, PERM lack of op checking
> - touch up switch statement formatting
>
>  kernel/auditfilter.c | 56 +++++++++++++++++++++++++++++++---------------------
>  1 file changed, 34 insertions(+), 22 deletions(-)

Merged into audit/next, thanks.

-- 
paul moore
www.paul-moore.com