[Linux-cachefs] Re: [PATCH 5/7] NFS: Use local caching [try #12]

[Chuck Lever]

Hi David-

On 8/18/06, David Howells <dhowells at redhat.com> wrote:
> The attached patch makes it possible for the NFS filesystem to make use of the
> network filesystem local caching service (FS-Cache).
>
> To be able to use this, an updated mount program is required.  This can be
> obtained from:
>
>         http://people.redhat.com/steved/cachefs/util-linux/
>
> To mount an NFS filesystem to use caching, add an "fsc" option to the mount:
>
>         mount warthog:/ /a -o fsc
>
> Signed-Off-By: David Howells <dhowells at redhat.com>
> ---
>
>  fs/Kconfig                 |    7 +
>  fs/nfs/Makefile            |    1
>  fs/nfs/client.c            |   11 +
>  fs/nfs/file.c              |   49 ++++-
>  fs/nfs/fscache.c           |  348 ++++++++++++++++++++++++++++++++
>  fs/nfs/fscache.h           |  476 ++++++++++++++++++++++++++++++++++++++++++++
>  fs/nfs/inode.c             |   21 ++
>  fs/nfs/internal.h          |   32 +++
>  fs/nfs/pagelist.c          |    3
>  fs/nfs/read.c              |   30 +++
>  fs/nfs/super.c             |    1
>  fs/nfs/sysctl.c            |   43 ++++
>  fs/nfs/write.c             |   11 +
>  include/linux/nfs4_mount.h |    1
>  include/linux/nfs_fs.h     |    5
>  include/linux/nfs_fs_sb.h  |    5
>  include/linux/nfs_mount.h  |    1
>  17 files changed, 1035 insertions(+), 10 deletions(-)
>
> diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c
> new file mode 100644
> index 0000000..94d5e3a
> --- /dev/null
> +++ b/fs/nfs/fscache.c
> @@ -0,0 +1,348 @@
> +/* fscache.c: NFS filesystem cache interface
> + *
> + * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved.
> + * Written by David Howells (dhowells at redhat.com)
> + *

> +
> +static uint16_t nfs_server_get_key(const void *cookie_netfs_data,
> +                                  void *buffer, uint16_t bufmax)
> +{

Why don't you use the function declaration style that is used in the
rest of the NFS client?  All the parameters belong on one line, don't
they?

-- 
"We who cut mere stones must always be envisioning cathedrals"
   -- Quarry worker's creed