[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Linux-cluster] [PATCH]Comments in gfs_ondisk.h



On Tue, Sep 07, 2004 at 07:02:33PM -0700, Cahill, Ben M wrote:
> Hi all,
> 
> Attached please find patch for cluster/gfs-kernel/src/gfs/gfs_ondisk.h.
> 
> I've added a lot of comments, and edited some pre-existing comments, to
> help briefly document the on-disk layout.  No other changes were made.
> I hope this is helpful.

Great, this is really helpful!  Thanks.

> Please let me know if you see anything wrong.

A few things:

o  Dinode stands for "disk inode".  Other UNIXes make the distinction
   between different versions of an inode:
     "dinode" -> ondisk representation of the inode
     "inode" -> the FS-specific representation of the inode
     "vnode" -> the VFS' representation of the inode
   Linux tends to call everything "inode", which can get confusing
   sometimes.

o  The locations of the special inodes is protected by GFS_SB_LOCK (as
   are all the fields in the superblock), but the regular inode locks on
   those inodes protect their contents.  The original comments in the
   code were really wrong.  (I don't think GFS_ROOT_LOCK ever existed.)

o  di_incarn is now unused, the functionality got moved to mh_incarn.

I checked in the fixed version.  Thanks, again.

-- 
Ken Preslan <kpreslan redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]