[Linux-cluster] Re: [PATCH 00/14] GFS
Arjan van de Ven
arjan at infradead.org
Wed Aug 3 09:17:09 UTC 2005
On Wed, 2005-08-03 at 11:56 +0800, David Teigland wrote:
> The point is you can define GFS2_ENDIAN_BIG to compile gfs to be BE
> on-disk instead of LE which is another useful way to verify endian
> correctness.
that sounds wrong to be a compile option. If you really want to deal
with dual disk endianness it really ought to be a runtime one (see jffs2
for example).
> > * Why use your own journalling layer and not say ... jbd ?
>
> Here's an analysis of three approaches to cluster-fs journaling and their
> pros/cons (including using jbd): http://tinyurl.com/7sbqq
>
> > * + while (!kthread_should_stop()) {
> > + gfs2_scand_internal(sdp);
> > +
> > + set_current_state(TASK_INTERRUPTIBLE);
> > + schedule_timeout(gfs2_tune_get(sdp, gt_scand_secs) * HZ);
> > + }
> >
> > you probably really want to check for signals if you do interruptible sleeps
>
> I don't know why we'd be interested in signals here.
well.. because if you don't your schedule_timeout becomes a nop when you
get one, which makes your loop a busy waiting one.
More information about the Linux-cluster
mailing list