[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Linux-cluster] Re: GFS



Hi David,

+             return -EINVAL;
+     if (!access_ok(VERIFY_WRITE, buf, size))
+             return -EFAULT;
+
+     if (!(file->f_flags & O_LARGEFILE)) {
+             if (*offset >= 0x7FFFFFFFull)
+                     return -EFBIG;
+             if (*offset + size > 0x7FFFFFFFull)
+                     size = 0x7FFFFFFFull - *offset;

Please use a constant instead for 0x7FFFFFFFull. (Appears in various other places as well.)


Pekka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]