[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Linux-cluster] Re: [-mm patch] drivers/dlm/: possible cleanups



On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - every file should #include the headers containing the prototypes for
>   it's global functions

Including unnecessary headers doesn't sound right.

> - make needlessly global functions static
> - #if 0 the following unused global functions:
>   - device.c: dlm_device_free_devices
>   - lock.c: dlm_remove_from_waiters
>   - lockspace.c: dlm_find_lockspace_name

I've removed the unused functions and added the statics.

Thanks,
Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]