[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Linux-cluster] Re: [-mm patch] drivers/dlm/: possible cleanups



On Mon, Nov 07, 2005 at 02:04:31PM -0600, David Teigland wrote:
> On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - every file should #include the headers containing the prototypes for
> >   it's global functions
> 
> Including unnecessary headers doesn't sound right.
>...

They aren't unnecessary.

If you #include them, gcc can tell when the prototypes in the header and 
the C file are accidentially different.

Without the #include's, this would result in a nasty runtime error.

> Thanks,
> Dave

cu
Adrian

BTW: Please ignore the resending of this patch that overlapped with
     your answer.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]