[Linux-cluster] [PATCH] Fix fence_agent string not correctly sent over the cluster.

[Simone Gotti]

Hi all,

on the openais based cman-2.0.35-2.el5 I noticed that the output of
"cman_tool nodes -f" provided a not correctly terminated fence agent
name:

[root at nodo01 ~]# cman_tool nodes -f
Node  Sts   Inc   Joined               Name
   1   M      4   2007-01-05 17:39:27  nodo01
   2   X      0                        nodo02
       Last fenced:   2007-01-05 17:39:41 by fence-node02!�
                                                         ^^

I think the problem is in the function do_cmd_update_fence_info in
cman/daemon/commands.c that calculate the bytes needed by the message to
send without counting the \0 terminating the fence_agent string.

I found also another similar problem in another point of the file and I
changed also it, but without testing.

I made a little patch and I hope it's correct.

Thanks!

Bye!
-- 
Simone Gotti

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Acquista i tuoi gioielli in tutta sicurezza ed a prezzi veramente imbattibili. Sfoglia il nostro catalogo on-line!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=5634&d=5-1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cman-2.0.35-cman-do_cmd_update_fence_info-msg_size.patch
Type: text/x-patch
Size: 1038 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20070105/611fe1ac/attachment.bin>