[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Linux-cluster] [PATCH] Fix fence_agent string not correctly sent over the cluster.



Simone Gotti wrote:
> Hi all,
> 
> on the openais based cman-2.0.35-2.el5 I noticed that the output of
> "cman_tool nodes -f" provided a not correctly terminated fence agent
> name:
> 
> [root nodo01 ~]# cman_tool nodes -f
> Node  Sts   Inc   Joined               Name
>    1   M      4   2007-01-05 17:39:27  nodo01
>    2   X      0                        nodo02
>        Last fenced:   2007-01-05 17:39:41 by fence-node02!�
>                                                          ^^
> 
> I think the problem is in the function do_cmd_update_fence_info in
> cman/daemon/commands.c that calculate the bytes needed by the message to
> send without counting the \0 terminating the fence_agent string.
> 
> I found also another similar problem in another point of the file and I
> changed also it, but without testing.
> 
> I made a little patch and I hope it's correct.
> 


Another good patch, now in CVS :)

Thank you very much.

-- 

patrick


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]