[Linux-cluster] [PATCH] qdisk: fix crash or wrong behavior if "qdisk_read" returns an error.
Lon Hohberger
lhh at redhat.com
Wed Jan 10 17:56:57 UTC 2007
On Wed, 2007-01-10 at 17:08 +0100, Simone Gotti wrote:
> In qdisk/main.c:read_node_blocks if the call to "qdisk_read" returns an
> error, the cycle isn't interrupted and the call swab_status_block_t will
> make qdiskd crash or report bad node id, master status etc.... This will
> probably (not reproduced) cause strange behavior like this node trying
> to kill the others that are working correctly.
>
> I putted a "continue" to skip the cycle after the error. As if nothing
> about the node can be read it's better to not change the current
> informations.
>
> I hope the patch is correct.
It looks right.
-- Lon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20070110/7dd7c083/attachment.sig>
More information about the Linux-cluster
mailing list