[Linux-cluster] [PATCH] fix schema for fence_virsh

[Fabio M. Di Nitto]

Guido Günther wrote:
> Hi,
> fence_virsh needs a port element but it's not allowed per schema so
> validation fails. Attached patch adds the port element to the schame for
> 3.0.4.
> Chees,
>  -- Guido

Hi Guido,

thanks for the patch, as you spotted yourself is not required.

Changes to the RelaxNG schema are still "a bit" delicate.

The fence-agents and resource-agents bits are automatically generated by
using the metadata output of the *-agents themselves.

So if you find a bug in that area, the correct fix is probably hidden
down in the agent itself.

For distribution purposes, I strongly discourage local patching of the
schema.

Just report the issue to us ASAP. Because the schema is new, we are very
responsive to fix bugs related to it and we can provide the correct fix
straight into git (that you can cherry pick safely since it will be part
of the next release).

There are also other bits that need to be updated when the RelaxNG
schema change, such as the LDAP schema file. A bad, un-coordinate
change, could result in a wrong generation of the LDAP schema file,
breaking compatibility between distributions and eventually upgrades
within the same distribution.

So, bottom line, just be careful when/if you touch it.

Cheers
Fabio