[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Linux-cluster] fence_ovh - Fence agent for OVH (Proxmox 3)



----- Mensaje original ----- 

> Hi Adrian,

> On 06/26/2013 07:55 PM, Adrian Gibanel wrote:
> > I've improved my former fence_ovh script so that it works in
> > Proxmox 3 and so that it uses suds library as I was suggested in
> > the linux-cluster mailing list.
> >
> > 1) What is fence_ovh
> >
> > fence_ovh is a fence agent based on python for the big French
> > datacentre provider OVH. You can get information about OVH on:
> > http://www.ovh.co.uk/ . I also wanted to make clear that I'm not
> > part of official OVH staff.
> >
> Thanks, you have done a great job in that rewrite. I have modified it
> a
> little to better fit into our existing infrastructure (--verbose,
> --plug). The only real change that I have added is that SOAP is not
> disconnected after every operation. Please take a look at it and
> (very
> likely) fix minor errors which I have introduced as I was not able to
> test it.

Thank you Marek!

  About the SOAP disconnection it's ok you not logging out at each time but I think the soap login should be tried just before calling the reboot_time function. The reason is that I'm afraid that 150 or 240 seconds are long enough for session to timeout. Maybe they are not but I prefer to be in the safe side.

  I have not tested it yet too but I've seen some changes that can made to it:

	elif options["--action"] in  ['on', 'off' ]:
should be:
	elif options["--action"] in  ['on', 'reboot' ]:

And at:

session = soap.service.login(options["--username"], options["--password"], 'es', 0)

You should use 'en' instead of 'es' so that default errors are printed in English by default.

Again, thank you!

-- 

-- 
Adrián Gibanel 
I.T. Manager 

+34 675 683 301 
www.btactic.com 



Ens podeu seguir a/Nos podeis seguir en: 

i 


Abans d´imprimir aquest missatge, pensa en el medi ambient. El medi ambient és cosa de tothom. / Antes de imprimir el mensaje piensa en el medio ambiente. El medio ambiente es cosa de todos. 

AVIS: 
El contingut d'aquest missatge i els seus annexos és confidencial. Si no en sou el destinatari, us fem saber que està prohibit utilitzar-lo, divulgar-lo i/o copiar-lo sense tenir l'autorització corresponent. Si heu rebut aquest missatge per error, us agrairem que ho feu saber immediatament al remitent i que procediu a destruir el missatge . 

AVISO: 
El contenido de este mensaje y de sus anexos es confidencial. Si no es el destinatario, les hacemos saber que está prohibido utilizarlo, divulgarlo y/o copiarlo sin tener la autorización correspondiente. Si han recibido este mensaje por error, les agradeceríamos que lo hagan saber inmediatamente al remitente y que procedan a destruir el mensaje . 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]