[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] IOP selection scripts (was: '/etc/init.d/lvm' scriptin debian package)



On Wed, 20 Dec 2000, Andreas Dilger wrote:

> Claudio writes:
> > if [ "$util" = "lvm-wrapper" ]; then
> >     echo "$util: you don't want to call the wrapper directly" 1>&2
> >     exit -2
>            ^^ I don't think this is legal...
> > fi

Oops. C-ism, I think.


> Is there ever a reason why you would want to install this program as
> "lvm-wrapper" anywhere?

I'm installing it as /sbin/lvm-wrapper and symlinking all utilities to it
(seems better than using one wrapper per tool).


> Probably some simple checks for the existence of /lib/lvm-iop$iop and
> /lib/lvm-iop$iop/$util and printing a nice message would be helpful, like:
> 
> if [ ! -d $LIBLVM ]; then
> 	echo "$util: $LIBLVM not found.  Is $LVMPKG installed?" 1>&2
> 	exit 3
> fi
> exec $LIBLVM/$util "$@"	# this will print out a localized error message for us

Indeed, it's better. Thanks.

Regarding lvmiopversion, is it supposed to be statically linked? Otherwise,
it wouldn't know what liblvm link to, assuming that we have liblvm-iopX.so.


claudio



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]