[linux-lvm] Problem using lvreduce
Joe Thornber
thornber at btconnect.com
Fri Aug 17 13:14:33 UTC 2001
On Fri, Aug 17, 2001 at 03:05:40PM +0200, Goetz Bock wrote:
>
> On Fri, Aug 17 '01 at 11:43, Joe Thornber wrote:
> > > --- pv_release_pe.c.old Thu Aug 16 09:23:35 2001
> > > +++ pv_release_pe.c Wed Aug 15 09:09:06 2001
> > > @@ -85,7 +85,7 @@
> > > }
> > > pe_index = ( vg->lv[l]->lv_current_pe[p].pe -
> > > LVM_VGDA_SIZE ( vg->pv[pv_num]) / SECTOR_SIZE) /
> > > - vg->pe_size;
> > > + vg->pe_size - 1;
> > > debug ( "pv_release_pe -- pv_name: %s pe: %lu sector: %lu\n",
> > > vg->pv[pv_num]->pv_name,
> > > pe_index,
> >
> > This patch looks wrong, I cant see why anyone would want to divide by
> > pe_size - 1, if it's working it's by accident.
> Disclamer: I did not lok at the code, and don't know what I
m talking
> about ...
>
> But, what this patch does, is devide by pe_size and substract 1 from the
> result.
doh, parse error !
Still wrong.
- Joe
More information about the linux-lvm
mailing list