[linux-lvm] $(DESTDIR) inclusion into Makefile.in files

[Friedrich Lobenstock]

On Fri, 15 Jun 2001, AJ Lewis wrote:

> On Fri, Jun 15, 2001 at 12:12:09PM +0200, Gergely Tamas wrote:
> > It would be probably a good idea to insert a $(DESTDIR) in front of all
> > installation targets. This would make packagers life easyer.
>
> Thanks Gergely,
> I've been intending to do that but hadn't yet.  Instead of putting it in the
> Makefiles themselves though, I put it where the install directories are
> defined, make.tmpl.in.  The head of the current CVS has these changes.

When modifying makefiles for packaging I'd do it the same way as
Gregely because what if the "make install" creates a symlink to let's
say /usr/bin/some-file which now would link it to
$(DESTDIR)/usr/bin/some-file and so we'd break the whole thing. Also
some other stuff like config files end up wrongly referenced in the
compiled files. So I'd say, never do it where the install directories
get defined, use $(DESTDIR) only in the install section of the
makefile.

Just my 2 euro cents.

-- 
MfG / Regards
Friedrich Lobenstock