[linux-lvm] Re: [PATCH LVM2] (3/3) add 'cling' allocation policy

[Alasdair G Kergon]

On Fri, Oct 06, 2006 at 05:56:54PM -0400, Jun'ichi Nomura wrote:
> This patch adds 'cling' allocation policy.

Applied.
Needed to reset preferred_count at the top of the outer loop.
(Was no need previously as contiguous had exactly one possible
match so was pointless going round the loop again so it didn't.)

> +				} else if (cling) {
> +					if (prev_lvseg &&
> +					    _check_same_pv(prev_lvseg,
> +							   pva, areas,
> +							   areas_size)) {
> +						prefered_count++;
>  						goto next_pv;
>  					}
>  					continue;

goto next_pv here - pointless repeatedly testing the same PV - if
it didn't match once it won't again

Alasdair
-- 
agk at redhat.com