[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] [PATCH 01/35] fsadm: Add "create" command



Dne 22.9.2011 11:28, Lukas Czerner napsal(a):
> On Wed, 21 Sep 2011, Stephane Chazelas wrote:
> 
>> 2011-09-21 18:45:20 +0200, Lukas Czerner:
>>> Create command provides the functionality of creating a new logical
>>> volumes including defined file system.
>>>
>>> This commit also changes the way how are commands recognised an
>>> executed. The new approach is more suitable for bigger number of
>>> commands.
>>
>> There are so many shell scripting bad practices in there that I
>> thought I had to reply.
> 
> Great, that's what I need, Thanks!
> 
>>
 So above:
>>
>> TOOL=$(basename -- "$0")
>>
>>>  
>>>  _SAVEPATH=$PATH
>>
>> Why would you need to save $PATH?
> 
> Yeah, that is something I would like to know as well :) I have actually
> removed this in patch 24 since it does not make sense to change PATH in
> this script.

When we are at this one - this commit definitely does not belong into the
fsadm update patch set - such patch should be submitted as a separate
unrelated patch and not 'well' hidden in the middle - and there are more such
things which should probably go separately - especially if they present some
bugfixes and should be merged before this large fsadm gets slowly upstream.

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]